This PR just adds the minor changes required for Craft 4 support. The changes also requires PHP 8, consistent with the syntax changes required and Craft 4's minimum requirements.
I'd probably also suggest renaming the repo to craft-codemirror from craft3-codemirror, as I don't think a separate fork is required for Craft 4 support, and it'd only make sense to maintain separate branches if you want to continue to support a version that doesn't require PHP 8.
luwes
commented
2 years ago
This PR just adds the minor changes required for Craft 4 support. The changes also requires PHP 8, consistent with the syntax changes required and Craft 4's minimum requirements.
I'd probably also suggest renaming the repo to craft-codemirror from craft3-codemirror, as I don't think a separate fork is required for Craft 4 support, and it'd only make sense to maintain separate branches if you want to continue to support a version that doesn't require PHP 8.