luwes / js-diff-benchmark

Simple benchmark for testing your DOM diffing algorithm.
67 stars 5 forks source link

Fix #16 - Dommy refactoring with better performance #19

Closed WebReflection closed 4 years ago

WebReflection commented 4 years ago

As discussed in https://github.com/luwes/js-diff-benchmark/issues/16, the current Dommy implementation might not satisfy most libraries, or work as expected.

This MR uses a more DOM friendly API, enabling possible usage of real DOM, or better DOM based libraries, plus it adds Prepend benchmark, in which Snabdom seems to constantly fail, while Spect randomly fails on the random benchmark.

Other libraries seems to be OK.

P.S. failing libraries should not be placed on top of the table, imho, but we need to wrap console.assert in order to spot which library failed where, or at least flag the whole cell as red/invalid.

WebReflection commented 4 years ago

Current Status

Note that snabdom failed.

Screenshot from 2020-04-17 14-35-13

luwes commented 4 years ago

I'll merge, can fix Snabbdom later