search

luwes / js-diff-benchmark

Simple benchmark for testing your DOM diffing algorithm.
66 stars 5 forks source link

Correctness of the benchmark #41

Closed Freak613 closed 3 years ago

Freak613 commented 3 years ago

As I understand, results published in README are results from running tests on node. After running benchmark multiple times on Chrome 89 with 6x CPU throttling I barely can get 3% difference between stage0 and udomdiff reconcilers, while results in node (and README) look like there is almost x3 slowdown difference between them. Results between 5 of 6 libraries are very minimal, with only heckel having noticeable hit. I would recommend to use only browser results, they do not change the winner, but can ease bad representation of other libraries. Also I think results in the browser are much more stable, especially with throttling, without hunting for randomized milliseconds in node.

Screenshot 2021-04-07 at 20 58 33
luwes commented 3 years ago

Thanks for double checking @Freak613 , I'm fine with only adding these results as image in the readme, will approve PR.

I can't say 100% sure but it seems on the js-framework-benchmark stage0 is still the fastest and I noticed the fallout from this when Sinuous got updated in the bench 😅 https://github.com/krausest/js-framework-benchmark/pull/858#issuecomment-787472913

Freak613 commented 3 years ago

Created PR: https://github.com/luwes/js-diff-benchmark/pull/42

Freak613 commented 3 years ago

Thanks, updated readme makes more sense.