search

luwes / wesc

We are the Superlative Components!
https://wesc-nextjs.vercel.app
21 stars 0 forks source link

feat: add addEventListener and removeEventListener to globalThis shims #4

Closed dwirz closed 11 months ago

dwirz commented 11 months ago

Hi there again @luwes 🙂

beside the rendering problem i mentioned in my other pull request #3 we have the problem that our components register event listeners on the window which atm is not supported by your globalThis shim.

Is there a reason you didn't add addEventListener and removeEventListener to globalThis? Otherwise would it be possible to add them see my PR? If you see any problem with this or don't want to add it let me know and we solve it on our side by extend the globalThis when rendering on server side.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wesc-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:35am
wesc-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:35am
wesc-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:35am
netlify[bot] commented 11 months ago

Deploy Preview for wesc-eleventy canceled.

Name Link
Latest commit b35e005d11acf381a31c42a785cc4540d62552c2
Latest deploy log https://app.netlify.com/sites/wesc-eleventy/deploys/6523c9153dcee000084b8b17
netlify[bot] commented 11 months ago

Deploy Preview for wesc-remixrun canceled.

Name Link
Latest commit b35e005d11acf381a31c42a785cc4540d62552c2
Latest deploy log https://app.netlify.com/sites/wesc-remixrun/deploys/6523c915995543000865ae96
netlify[bot] commented 11 months ago

Deploy Preview for wesc-node canceled.

Name Link
Latest commit b35e005d11acf381a31c42a785cc4540d62552c2
Latest deploy log https://app.netlify.com/sites/wesc-node/deploys/6523c915e10bc10008abbb7a
dwirz commented 11 months ago

see comment in #3