search

lux-org / lux

Automatically visualize your pandas dataframe via a single print! 📊 💡
Apache License 2.0
5.15k stars 365 forks source link

Fixing to Choropleth width and int type error #395

Closed dorisjlee closed 3 years ago

dorisjlee commented 3 years ago

Overview

@cjachekang reported an issue with integer type geographic columns, as shown in the communities dataset. image (15) This PR fixes the issue and displays the integer state columns based on their FIPS directly. In addition, this PR also increases the width of choropleth charts so that the visualizations don't appear to be too squished horizontally.

codecov[bot] commented 3 years ago

Codecov Report

Merging #395 (7fc298e) into master (2b6e162) will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   84.93%   85.02%   +0.08%     
==========================================
  Files          52       52              
  Lines        4030     4033       +3     
==========================================
+ Hits         3423     3429       +6     
+ Misses        607      604       -3
Impacted Files Coverage Δ
lux/vislib/altair/AltairChart.py 91.80% <100.00%> (+0.27%) :arrow_up:
lux/vislib/altair/Choropleth.py 92.95% <100.00%> (+8.67%) :arrow_up:
lux/vislib/altair/Heatmap.py 93.10% <0.00%> (-3.45%) :arrow_down:
lux/vislib/matplotlib/Heatmap.py 96.66% <0.00%> (-1.67%) :arrow_down:
lux/vislib/matplotlib/ScatterChart.py 75.58% <0.00%> (-1.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b6e162...7fc298e. Read the comment docs.