search

lux-org / lux

Automatically visualize your pandas dataframe via a single print! 📊 💡
Apache License 2.0
5.15k stars 365 forks source link

FIX-#403: Fixes mixed-dtype problem in execute_2D_binning #448

Closed cgarciae closed 2 years ago

cgarciae commented 2 years ago

Overview

Mixed dtype columns cause execute_2D_binning to crash when trying to bin via pd.cut, this error shows up frequently in users code (#403, #394).

Changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #448 (ab3a2df) into master (a7e2cf7) will decrease coverage by 0.16%. The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   65.65%   65.49%   -0.17%     
==========================================
  Files          55       55              
  Lines        4440     4454      +14     
==========================================
+ Hits         2915     2917       +2     
- Misses       1525     1537      +12
Impacted Files Coverage Δ
lux/core/series.py 36.11% <0.00%> (ø)
lux/executor/PandasExecutor.py 86.04% <14.28%> (-3.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7e2cf7...ab3a2df. Read the comment docs.