json.MarshalIndent and json.Encoder.SetIndent doesn't indent output from json.Marshaller implementers, which means that e.g. k8s.io/apimachinery/pkg/apis/meta/v1/unstructured objects are never marshalled with the right indentation. This could be fixed upstream in encoding/json or github.com/json-iterator/go by walking (using an JSON iterator) the []byte return value of MarshalJSON(), and indenting accordingly whenever the right tokens are found.
As far as I understand, the implementations mentioned already validate the output of MarshalJSON(), i.e. verify that the syntax is correct, and as such already do "most" of the work needed.
The workaround for this would be to first do a normal Marshal of the object, and then do a json.Indent into a temporary buffer, only to later return the buf.Bytes() in case of MarshalIndent or write the buffer contents to the underlying io.Writer. It would of course be nice if json.Indent supported writing directly to any io.Writer, so the buffer "middle-man" could be avoided.
json.MarshalIndentandjson.Encoder.SetIndentdoesn't indent output fromjson.Marshallerimplementers, which means that e.g.k8s.io/apimachinery/pkg/apis/meta/v1/unstructuredobjects are never marshalled with the right indentation. This could be fixed upstream inencoding/jsonorgithub.com/json-iterator/goby walking (using an JSON iterator) the[]bytereturn value ofMarshalJSON(), and indenting accordingly whenever the right tokens are found.As far as I understand, the implementations mentioned already validate the output of
MarshalJSON(), i.e. verify that the syntax is correct, and as such already do "most" of the work needed.The workaround for this would be to first do a normal
Marshalof the object, and then do ajson.Indentinto a temporary buffer, only to later return thebuf.Bytes()in case ofMarshalIndentor write the buffer contents to the underlyingio.Writer. It would of course be nice ifjson.Indentsupported writing directly to anyio.Writer, so the buffer "middle-man" could be avoided.