search

luxeengine / alpha

alpha - deprecated 2015~2016. unrelated to the new engine! view the new engine here - https://luxeengine.com/
MIT License
565 stars 74 forks source link

phoenix; Matrix; fix element indices in get/set `m` values #405

Closed le-doux closed 7 years ago

le-doux commented 7 years ago

Right now the indices for the individual matrix element getters and setters are in reverse order from the constructor, set, and tostring

le-doux commented 7 years ago

just a note: the order used by the getters / setters makes more sense to me (left-to-right order instead of up-down order) and might be easier to work with, but the rest of the class uses the other ordering, so I changed the getters / setters. it should work just as well to do the opposite.

ruby0x1 commented 7 years ago

@le-doux I think I see what you mean, I'll merge this and then reorder it to double check.

ruby0x1 commented 7 years ago

Actually, I think the fix might not be correct after all! I'm making sure and fixing some other minor stuff in there as well. Edit: or i've confused myself further.

ruby0x1 commented 7 years ago

It seems I did confuse myself when editing it for clarity, but it looks more sound now thanks @le-doux

le-doux commented 7 years ago

thanks for the quick response Sven! looks good now :)