add_flag() doesn't add flags to any C++ files in project

luxonis / XLink

A cross-platform library for communicating with devices over various physical links.

Apache License 2.0

11 stars 17 forks source link

add_flag() doesn't add flags to any C++ files in project #68

Open diablodale opened 1 year ago

diablodale commented 1 year ago

add_flag() in this project's cmake doesn't add flags to C++ files. I suspect when c++ files were added to the project, the dev didn't update cmake to support them.

Trivial fix now in my fork. Will link to this issue below. Easy cherry pick.

diablodale commented 1 year ago

commit above.

cmake changes including bumping up one dot release of cmake to 3.3 due to existing code already uses 3.3 features like $<COMPILE_LANGUAGE
one source file must be updated due to correctly applied flags. More signed/unsigned mismatches. There are more....