search

luxonis / XLink

A cross-platform library for communicating with devices over various physical links.
Apache License 2.0
11 stars 17 forks source link

Fix missing link to required library in Windows when XLINK_LIBUSB_SYSTEM is ON #79

Closed traversaro closed 1 month ago

traversaro commented 1 month ago

The PathCchRemoveFileSpec function contained in Pathcch.lib is called in the code in Windows (see https://github.com/luxonis/XLink/blob/6d2a0dd2e7f0f08657b492ec684a493d7ab1c2a0/src/pc/Win/src/win_usb_host.cpp#L39), so the Pathcch.lib library should be linked even if XLINK_LIBUSB_SYSTEM is set to ON.

traversaro commented 1 month ago

The Windows failure is unrelated and related to https://github.com/luxonis/depthai-core/pull/1037 and https://github.com/cpp-pm/hunter/pull/747 .

traversaro commented 1 month ago

The merge confused the PR, let me do it from scratch.

traversaro commented 1 month ago

The merge confused the PR, let me do it from scratch.

Ok, now it is clean, let me know if it is ok to merge with squash or you prefer that I cleanup the history.