search

luxonis / depthai-core

DepthAI C++ Library
MIT License
235 stars 127 forks source link

New xlink version #1093

Closed onthegrid007 closed 3 months ago

onthegrid007 commented 3 months ago

Hello,

I made a pull request to the xlink repository to allow clang as a working compiler on windows, Linux, etc. Now I am wondering how to get depthai and or hunter to pull the new updated repo so I don't have to use the depthai local xlink flag in cmake to get depthai-core to compile properly...

I have looked through the CMake file here in this repo and can't even find where xlink is being pulled into hunter from, otherwise I would make a pull request...

Any help would be appreciated!

-onthegrid007

themarpe commented 3 months ago

@onthegrid007 the change can be done in cmake/Hunter/config.cmake

Note, open PRs to develop

onthegrid007 commented 3 months ago

Found it thank you. Can I inquire, why not to master?

themarpe commented 3 months ago

@onthegrid007 great! Of course - mainly due to keeping main "stable", while the intermediary development, bugfixes, etc.. happen in develop. After everything is tested together will multiple PRs landed, then a release to mian is made