search

luxonis / depthai-unity

DepthAI Unity Library, Unity projects and examples (OAK For Unity)
MIT License
200 stars 34 forks source link

UPDATE: MRKT HL2 #10

Closed jbb-kryo closed 2 years ago

jbb-kryo commented 2 years ago

Direct streaming of Oak-D output to Hololens 2 via Hololens Remote Player:

gespona commented 2 years ago

Hi ! First and foremost thank you for contributing to the repository. I had no time to write down the steps to contribute properly but open PR like this is fine. The only thing to take in consideration is I don't want to merge into main until we reach v1.0 in beta branch (according the roadmap). Do you mind to open same PR but against beta branch ?

gespona commented 2 years ago

Hi ! I'm checking the last patch and I see you worked on top of the URP project. Nothing wrong here too but I want to remark the compatibility thing. Non specific platform scenes should work fine for Mac/Linux/Win. Also the idea of the basic plugin has minimum package dependencies as the idea is to create .unitypackage to import in existing projects. I put URP project under folder OAKForUnity with the idea to add more unity projects (HDRP, Robotics, Synth data) .. Maybe it's good approach to very specific projects/examples. Thoughts? But anyway if you could send PR against beta I can review more easily and then we can take final decision on how to merge it to the repo, ok?

jbb-kryo commented 2 years ago

No problem. I completely understand. I have closed this CR and I have opened a new one under the beta track as requested. I like the idea of keeping project specific components as packages that can be dropped and added as required. Way more flexible in the long run. Whatever you do right now - it's still going to be better than the Kinect DK workflow. :D