luxonis / depthai-unity

DepthAI Unity Library, Unity projects and examples (OAK For Unity)
MIT License
200 stars 34 forks source link

[UPDATED] MRTK + HL2 Support #11

Closed jbb-kryo closed 2 years ago

jbb-kryo commented 2 years ago

Direct streaming of Oak-D output to Hololens 2 via Hololens Remote Player:

gespona commented 2 years ago

Hi ! I checked the PR and think this case is good example as project using the plugin more than integrate inside the sample URP project. So my suggestion here is to add the project under OAKForUnity folder as Holo2 or something similar. Sounds good? Also makes me think about the .unitypackage so we don't make the repo really heavy (as unity projects are not very light ;) ) So the idea anyway was to release .unitypackage to import Plugins->OAKForUnity in any external project. So I can add .unitypackage as part of github release and just add a reference in your project. All that said .. what is your idea about hololens integration ... I mean are you planning to work further on this project? I'm asking because if the idea is to develop more and more on this project .. then maybe the right way to integrate in fact is like a submodule pointing to your repo or simply adding the reference of your repo on example projects. Thoughts?

jbb-kryo commented 2 years ago

I'm definitely at doing more development to the HL2 implementation. There's a couple of options based on use case I'm considering.

What do you think? I'm thinking that directly including HL2 support into the core OFU plugin will be adding to the overall plugin maintenance load. Nothing worse than awesome plugin failing because of one of the damned dependencies. And given Microsoft's interesting discussions around HoloLens 3 and that family of devices, I think it would be wise not to make HL2 support a core dependency or inclusion. Separate package module I think is best, as you've suggested.

gespona commented 2 years ago

Yep totally agree. With all the context makes sense to have it as separate project. For now if it's ok for you I will close this PR and first I will create section on readme for Community Projects and points to your github repo and then I can add as submodule under OAKForUnity folder. And again thank you for your contribution :)