Fix depth-less Face Detector pipeline

luxonis / depthai-unity

DepthAI Unity Library, Unity projects and examples (OAK For Unity)

MIT License

200 stars 34 forks source link

Fix depth-less Face Detector pipeline #66

Closed AndreiMoraru123 closed 2 weeks ago

AndreiMoraru123 commented 1 month ago

Hi @gespona,

Currently, the Dai Face Detector script crashes when setting UseDepth to false. This is because some cases were not handled in the source library.

This PR adds those checks. I also changed the default UseDepth to false, to show the intention, but I could revert it.

The rest of the diff is just whitespace, so you can look at it with the whitespace ignore option.

gespona commented 3 weeks ago

@AndreiMoraru123 Thank you again. Yes similar to previous case. The idea is to use UseDepth and missing some cases when False. Could you keep UseDepth=True by default? :) More than happy to review and merge then

AndreiMoraru123 commented 3 weeks ago

Updated. Thanks for looking into it!