search

luyadev / luya-module-admin

Administration base module for all LUYA admin modules
https://luya.io
MIT License
48 stars 56 forks source link

Outdated echarts.js #428

Closed jettero777 closed 4 years ago

jettero777 commented 4 years ago

Seems that echarts.js shipped with the package is outdated. I try to use charts with datasets and it is not working though it works on current echarts lib. Datasets were implemented there since 4.0 version.

In composer.json version of echarts is "bower-asset/echarts": "~3.8.5", which is 2 years old yet. I tried to update it via composer but looks like the lib is precompiled into js resources.

nadar commented 4 years ago

So then we might update the dependency, are there any major breaks we can expect from 3 to 4?

jettero777 commented 4 years ago

Here is changelog https://www.echartsjs.com/en/changelog.html#v4-0-0

Pie chart in User History uses very basic features and should work on latest echarts version too. There are changes in label options, but old formatting is still supported:

[+] Since ECharts4, the options label and itemStyle has been flattened. The original level of normal is not needed any more, which make ECharts option more neat. As always, The previous option style in ECharts3 is still be compatible.