luyadev / luya-module-cms

The LUYA CMS module provides a full functional CMS for adding contents based on blocks.
https://luya.io
MIT License
33 stars 46 forks source link

Preparation for missing translations in CRUD tables + AWS #370

Closed hbugdoll closed 3 years ago

hbugdoll commented 3 years ago

What are you changing/introducing

  1. Preparation for missing translations in CRUD tables regarding following models:

Translations for the primary keys id ("ID") are omitted.

Also replaced Yii::t('app', defaultValue) with Module::t(key) to hold all module translations together, so the AWESOME translators have to deal with only one i18n file.

  1. Little fix for displaying "ID" instead of "Id" in the block's detail view Active Window: https://github.com/luyadev/luya-module-cms/blob/7849af7f21c3c905d78c729e6699ac5321ef4d0f/src/models/Block.php#L98-L100

What is the reason for changing/introducing

Translations in some CRUD tables and AWS are missing.

QA

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues -
nadar commented 3 years ago

Amazing! Thanks!