search

luyadev / luya-module-cms

The LUYA CMS module provides a full functional CMS for adding contents based on blocks.
https://luya.io
MIT License
33 stars 46 forks source link

Fixes for NgRest models PHPDoc #373

Closed chemezov closed 2 years ago

chemezov commented 2 years ago

Hello!

What are you changing/introducing

I was fixed PHPDoc for relation properties, and return type for relations. Also some code and typo fixes.

What do you think about that? Should i continue this way for other models?

What is the reason for changing/introducing

My goal is fix autocomplete for IDE. Now it has wrong type, like $navItem->getNav() - return Nav, instead of NgRestActiveQuery.

QA

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? -
Fixed issues
nadar commented 2 years ago

this is perfect, thank you very much! I think for cms nav and cms nav item we should even create an own activequery class, but that might be a future improvement. Thanks, that's great and very appreciated as we are aware of that but just don't have time. (those are also some of the oldest code parts in luya)

chemezov commented 2 years ago

Great to hear that! I will continue working on these changes in the near future.