luyadev / luya-module-cms

The LUYA CMS module provides a full functional CMS for adding contents based on blocks.
https://luya.io
MIT License
33 stars 46 forks source link

add missing env informations to block #401 #403

Closed nadar closed 9 months ago

nadar commented 9 months ago

closes #401

hbugdoll commented 9 months ago

I've made new unit tests for the envOptions: https://github.com/luyadev/luya-module-cms/commit/ef4efcd366a6572d4bd1098cb8b4f92fb9dd1ae5.

And they have proven their worth – my 'equalIndex' iteration was wrong (post-increment vs. pre-increment), see https://github.com/luyadev/luya-module-cms/commit/2d3be0da2574b21f4fa29ab030b9e1470e9bca5d.

Block Test

Block Placeholder Iteration Test

nadar commented 9 months ago

@hbugdoll i will merge this PR.. You can send then a PR with only the unit tests and the according fix. ok? Afterwards we will take a look at the page object in another PR.

nadar commented 9 months ago

@hbugdoll you can now create a fresh merge request using the latest master (don't forget to create a branch on your fork).

hbugdoll commented 9 months ago

@hbugdoll you can now create a fresh merge request using the latest master (don't forget to create a branch on your fork).

Ok, done → #407