Make ./luya serve command work out of the box

luyadev / luya

LUYA is a scalable web framework and content management system with the goal to please developers, clients and users alike.

https://luya.io

MIT License

811 stars 205 forks source link

Make ./luya serve command work out of the box #1866

Closed cebe closed 5 years ago

cebe commented 5 years ago

What are you changing/introducing

Make ./luya serve command work out of the box.

What is the reason for changing/introducing

Before:

$ ./luya serve
Document root "/home/cebe/dev/cebe.cc/luya/web" does not exist.

After:

$ ./luya serve
Server started on http://localhost:8080/
Document root is "/home/cebe/dev/cebe.cc/luya/public_html"
Quit the server with CTRL-C or COMMAND-C.

QA

Q	A
Is bugfix?	yes
New feature?	yes
Breaks BC?	no
Tests pass?	n/a
Fixed issues	none

nadar commented 5 years ago

Nice! Thank you.

Maybe the configuration should be done here?

https://github.com/luyadev/luya/blob/master/core/console/Application.php#L42

coveralls commented 5 years ago

Coverage remained the same at 55.877% when pulling 335f015139709697282e904c4677e82604f753c6 on cebe:patch-1 into 811db931d9260c4f153e342f85def8266ba01827 on luyadev:master.

cebe commented 5 years ago

yes, did not see that place. Will update it.

cebe commented 5 years ago

done.