Url module controller context fix

luyadev / luya

LUYA is a scalable web framework and content management system with the goal to please developers, clients and users alike.

https://luya.io

MIT License

811 stars 205 forks source link

Url module controller context fix #1877

Closed boehsermoe closed 5 years ago

boehsermoe commented 5 years ago

This closes #1876

coveralls commented 5 years ago

Coverage increased (+0.01%) to 59.253% when pulling b7f9bd7517d17924c513b570871f97d8cd520c15 on boehsermoe:issue-1876 into 7ca61dde991152fcc2fb4dae73769e542add0948 on luyadev:master.

nadar commented 5 years ago

Yes, this could fix the problem. Unit test is failing it seems.

nadar commented 5 years ago

This comparison check is done a line above already: https://github.com/luyadev/luya/blob/273a03b1197e98eb7baed0ecdf354140905aaa26/core/web/UrlManager.php#L365

boehsermoe commented 5 years ago

I did some refactoring. Should be fix now.