luyadev / luya

LUYA is a scalable web framework and content management system with the goal to please developers, clients and users alike.
https://luya.io
MIT License
812 stars 207 forks source link

Keep basepath while theme loading #1970

Closed boehsermoe closed 4 years ago

boehsermoe commented 5 years ago

In loadThemeConfig the basepath should be keep as relative path and which should also saved into database.

https://github.com/luyadev/luya/blob/849532964e50b96969069adca01d884d9f8ad5e8/core/theme/ThemeManager.php#L57

nadar commented 4 years ago

I am not sure this is related, but cmslayouts doe not work with absolute paths:

View not Found – yii\base\ViewNotFoundException
The view file does not exist: /app/repos/luya-module-cms/src/frontend/views/app/vendor/nadar/luya-creative-theme/views/cmslayouts/theme.php

as by yii defintion the absolute path must start with double slashes:

https://www.yiiframework.com/doc/api/2.0/yii-base-view#render()-detail

Not sure we have to improve this in luya cms cmslayouts importer or theme manager, will do some research.