luyadev / luya

LUYA is a scalable web framework and content management system with the goal to please developers, clients and users alike.
https://luya.io
MIT License
811 stars 205 forks source link

JsonLD naming in the docs #2033

Closed JohnnyMcWeed closed 3 years ago

JohnnyMcWeed commented 4 years ago

What steps will reproduce the problem?

Checking the JsonLd Luya docs I saw that it is talking about Value Types.

What is the expected result?

Coming from the schema.org list view I'd suggest stating that this means all those declared as Data Types. I think this naming should be followed.

Moreover they are instances of DataType. This means, that the current BaseValue class should be changed aswell to follow the hierarchy of schema.org.

So: BaseValue should be renamed to BaseDataType (as compared to the BaseThing) Then there is a DataType And then there are the data types...

nadar commented 4 years ago

ValueTypes are only used to ensure people provide an URL or E-Mail or any other special value. This allows us to validate the user input. I would just keep those ...Values classes as it has nothing to do with Schema.

JohnnyMcWeed commented 4 years ago

So what's the point in not going for the default schema data types, which are explicitly for that?

nadar commented 3 years ago

I am going to close this issue because:

If you think this is still important or there are more/new informations. Please reopen the issue and let us know.

If this is a problem or a feature you like to discuss, join our forum: forum.luya.io. We try to keep our issue tracker as clean as possible in order to focus on active issues.