search

luyadev / luya

LUYA is a scalable web framework and content management system with the goal to please developers, clients and users alike.
https://luya.io
MIT License
812 stars 207 forks source link

LazyLoad IntersectionObserver update #2037 #2038

Closed TheMaaarc closed 4 years ago

TheMaaarc commented 4 years ago

See Changelog and Issue #2037.

This closes #2037

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit e34bb70e and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 7
Duplication 2

The test coverage on the diff in this pull request is 85.7% (80% is the threshold).

This pull request will bring the total coverage in the repository to 66.5% (0.0% change).

View more on Code Climate.

nadar commented 4 years ago

@TheMaaarc it seems that the node tests are failing https://github.com/luyadev/luya/pull/2038/checks?check_run_id=889017792

TheMaaarc commented 4 years ago

@nadar There seems to be an issue with the test. It works like 50% of the time. We can remove that test, that's the only thing I can offer. I don't have time to debug that atm.