Add local decks CRUD functionality to the options page

luzhanov commented 7 years ago

Right now we have only two local decks which are hardcoded here: defaultDataFiller.js:37 A primitive listing of decks implemented here options.js:109 and options.html:22

Please implement simple controls for a deck management. There are no strict requirements to the presentation.

ACCEPTANCE CRITERIA

[x] * User should be able to see all existing decks on the options.html page
[ ] * User should be able to delete any deck (except the last one). If the deck is not empty, user should be asked. On deletion: deck entry and LocalDB entry should be deleted
[x] * User can't delete the last deck
[ ] * User should be able to rename a deck. It renames deck entry and LocalDB entry
[x] * User should be able to create a new deck
[x] * If deleted deck was a current deck (localStorage["currentDeck"]) - first deck in list should be selected
[ ] * All decks should be listed in popup page deck select.
[ ] * Active deck should be selected on opening.
[ ] * Select should always show some deck, without possibility to show empty value.

luzhanov commented 7 years ago

@vvscode If you will have a time to implement this please comment it. It's the last issue before we can release the first "local saving" version of plugin.

vvscode commented 7 years ago

sure. Just added task list

vvscode commented 7 years ago

@luzhanov This one should be branched from 2.0.0_local_storage ?

and also - can you describe logic for current options.js, or I can replace all it's content ( related to decks ) and rewrite it in accordance with acceptance criteria?

luzhanov commented 7 years ago

@vvscode

This one should be branched from 2.0.0_local_storage ?

Yes

can you describe logic for current options.js, or I can replace all it's content ( related to decks ) and rewrite it in accordance with acceptance criteria?

I just thinking about "Hide decks" functionality - it's useless right now, but it can be reused later, when/if we will restore connectivity with Anki. I'd rather vote for commenting it on the options page, but not removing from the code. What do you think?

About "Keyboard shortcuts" - i think it should stay as is.

vvscode commented 7 years ago

https://github.com/luzhanov/anki-adder-plus/pull/14 work in progress

vvscode commented 7 years ago

@luzhanov there are two functions optionsLocalDecks / optionsListDecks . Both fill list of decks block. But second one remove result of first one -- what for do we need two functions? I support that second one should handle remove decks from ankiweb ( is it correct? ). Is it still actual?

vvscode commented 7 years ago

And also as far as I see - please add acceptance criteria for popup/form -- cause decks used and there too.

luzhanov commented 7 years ago

there are two functions optionsLocalDecks / optionsListDecks

My fault. optionsLocalDecks was written by me as a simple example, optionsListDecks was used before - i suppose we can remove it.

acceptance criteria for popup/form -- cause decks used and there too.

I'm expecting that we don't need any changes there - if decks will be stored in the same way as before than the popup form will handle them correctly

luzhanov commented 7 years ago

I added acceptance criteria for popup - now I understand that you need to make some changes there too

vvscode commented 7 years ago

I found https://chrome.google.com/webstore/detail/anki-adder-plus/ahdmkklclpffcjgfllibcojofffgdagd?hl=en -- The question is -- how user can create nested decks? ( or it's just a form of presentation based on names via :: ) ?

luzhanov commented 7 years ago

how user can create nested decks? ( or it's just a form of presentation based on names via :: ) ?

Yes, it's just a presentation of :: name notation

luzhanov / anki-adder-plus

Add local decks CRUD functionality to the options page #12