search

lv2 / pugl

A minimal portable API for embeddable GUIs
https://gitlab.com/lv2/pugl/
ISC License
181 stars 35 forks source link

MacOS transient parent isn't set on realize #79

Closed falkTX closed 1 year ago

falkTX commented 2 years ago

leaving a note for something to fix. everytime we call puglSetTransientParent, view->transientParent is saved/cached.

when we call this when there is a window, pugl macOS code does its job as expected. but if the window does not exist yet (view not realized), this value is ignored. seems to me when the window is created the code should check if there was a transient parent set, and if so take care of that then.

will send a PR later if needed. just going through the pugl changes for now and adjusting my code..

drobilla commented 1 year ago

Presumably fixed (if untested) in ef19bb7, thanks.

Other minor inconsistencies with transient parents also resolved, this was not a MacOS exclusive issue.