Closed mfisher31 closed 2 years ago
mmmm thanks, but I think this can be fixed by simply deleting that, ala 5d2da05
These tests are a bit weird, they're to test the case where people are (annoyingly) including pugl directly, so the suppressions shouldn't be mixed with the usual (and mixing flags across languages is generally a no-no).
With this, the non-strict and strict builds both build cleanly for me. Let me know and/or reopen if you still have problems.
Works for me! Thanks!
The
c_warnings
doesn't get defined unless-Dstrict=true
.test/meson.build
tries to access it when building for OSX and fails. Unless strict is enabled, this happens:I searched the code base and it appears
c_warnings
is used outside of the suppression stuff only once... and only on Mac. This patch appends c_warnings to the tests if strict is enabled. I didn't see in the meson docs a way to check for undefined variables (maybe I'm missing something), so I went this route.