search

lv2 / pugl

A minimal portable API for embeddable GUIs
https://gitlab.com/lv2/pugl/
ISC License
181 stars 35 forks source link

Double DEPRECATED results in compiler warnings #96

Closed sjaehn closed 1 year ago

sjaehn commented 1 year ago

https://github.com/lv2/pugl/blob/1e48f8bbfdb0f1ce2f9132d604405fb72d160d9d/include/pugl/pugl.h#L1611-L1621

The lower to typedefs link to the deprecated typedefs above and thus always result in compiler warnings. Intended? Or better directly typedef to PuglRealizeEvent and PuglUnrealizeEvent?

drobilla commented 1 year ago

I dunno. Whatever? Using the deprecated API stuff (which is just a courtesy to keep most things still compiling while I nail down the API) will, indeed, generate warnings. That's the whole point...

Note that this stuff is going to go away entirely at some point in the hopefully not-too-distant future. I suggest getting off the deprecated API as soon as possible, a little pain now means a lot less later.

sjaehn commented 1 year ago

But pugl itself shouldn't use its own deprecated symbols. Simple fix in https://github.com/lv2/pugl/pull/97

drobilla commented 1 year ago

Pugl itself is built without the deprecated API, it can't use any of it. I guess I see what you mean, but having PUGL_DISABLE_DEPRECATED undefined be as annoying as possible is kind of a pro for me :)

Anyway, I'll apply that when my damned internet connection comes back up, thanks.

drobilla commented 1 year ago

Fixed in 1d62260