search

lv2 / suil

Library for loading and wrapping LV2 plugin UIs
ISC License
11 stars 5 forks source link

fix macOS build #18

Closed chenrui333 closed 2 years ago

chenrui333 commented 2 years ago

fixes #17

drobilla commented 2 years ago

Thanks. Unfortunately, this breaks the build on Linux:

../src/qt5_in_gtk.cpp:128:31: error: invalid cast from type ‘GdkNativeWindow’ {aka ‘unsigned int’} to type ‘WId’ {aka ‘long long unsigned int’}

Seems like the types differ significantly across platforms. static_cast actually seems more sensible here to me (reinterpret_cast was just a guess, that's not appropriate for differently sized integers). Haven't managed a Mac build yet, I can't figure out where/if the required Qt things (QMacCocoaViewContainer) are in homebrew...

drobilla commented 2 years ago

Fixed (by instead reverting to C casts) in 2d18caf.