lvaldivia / open-video-ads

Automatically exported from code.google.com/p/open-video-ads
0 stars 0 forks source link

Click through URL should never be relative to flash path #19

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Flowplayer example (attached).   When I clicked the ad to go to the website, it 
wouldn't go to the 
absolute URL, but instead would append the URL to my OpenX VAST URL (as a 
relative URL).

<script type="text/javascript">
flowplayer("a.example", "../dist/flowplayer-3.1.3-dev.swf", {
    plugins: {
        controls: {
            autoHide: "always"
        },

        openAdStreamer: {
            url: '../dist/OpenAdStreamer.swf',
//            "url": "/fp-http/OpenAdStreamer.swf",

        "deliveryType": "streaming",
            "providers": { "rtmp": "../dist/flowplayer.rtmp-3.1.3-dev.swf" },

          "shows": {
            "baseURL": "rtmp://ne7c0nwbit.rtmphost.com/videoplayer",
              "streams": [ { "file":"mp4:the-black-hole.mp4", "duration":"00:00:10" } ]
          },

      "debug": {
              "debugger": "firebug",
              "levels": "fatal",
      },

        "ads": {
            "playOnce": false,
          "server": {
          "type": "OpenX",
              "vastURL": "http://localhost/282/www/delivery/fc.php",
             },
            "schedule": [
                {
                   "zone": "1",
                   "position": "pre-roll"
                }
            ]
      }
        }
    }
});
</script

Original issue reported on code.google.com by paul.sch...@gmail.com on 1 Sep 2009 at 5:51

GoogleCodeExporter commented 8 years ago

Original comment by paul.sch...@gmail.com on 1 Sep 2009 at 7:18

GoogleCodeExporter commented 8 years ago
On the 1) issue of the click through not going to an absolute URL... this one 
has me a little stumped.. I've just 
tried finding out what may cause this - when click throughs come through to me, 
they are wrapped with the 
redirect URL so I'm struggling to understand how a relative URL would end up 
getting fired.. the only things I 
can think of are:

1. The plugin isn't getting a click wrapped URL through in the first place for 
some reason - just the plain click 
through destination address or
2. Somehow I'm putting the wrong value into the click event on the plugin 
somehow (struggling to find that)

Best ping me on this one as well - we can debug easily together.

PS: I am going to make a code change to always check the click through URL and 
make sure it's being fired as 
an absolute path for safety anyway... 

Original comment by paul.sch...@gmail.com on 1 Sep 2009 at 7:32

GoogleCodeExporter commented 8 years ago

Original comment by paul.sch...@gmail.com on 1 Sep 2009 at 7:34

GoogleCodeExporter commented 8 years ago
For safety, added NetworkResource.qualifiedHTTPUrl() and replaced the "ad.url" 
with "ad.qualifiedHTTPUrl" to 
ensure that a click through URL value always starts with "http://" before it's 
fired off in the player. Doesn't 
address the original bug, but makes it safer just in case the right value isn't 
passed through in the first place

Original comment by paul.sch...@gmail.com on 1 Sep 2009 at 7:49

GoogleCodeExporter commented 8 years ago
The new version is "qualifiedHTTPUrl()" is VAST Framework 0.3.2

Original comment by paul.sch...@gmail.com on 1 Sep 2009 at 7:50

GoogleCodeExporter commented 8 years ago
Should be resolved now

Original comment by paul.sch...@gmail.com on 4 Sep 2009 at 9:39