search

lvanderree / com.synplyworks.thenmore

Homey Then functionality
GNU General Public License v3.0
0 stars 4 forks source link

Cancelation of timers does not work. #28

Open tice17 opened 8 months ago

tice17 commented 8 months ago

Hi,

I created diagnosis 00058206-0eaf-4f49-8a2a-d5bd2b25ccac. I have a simple flow that, when started, should cancel two running timers. The timers are NOT canceled like they should.

stofferr commented 2 months ago

Same issue. Even though my timer is cancelled, the light turns on again. Will we be able to expect a fix please?

stofferr commented 2 months ago

Also in the timers list, timers seem to disappear automatically after a few seconds after starting, but they are still running. This may also be the cause for timers to not being cancelled as they are no longer in the list.

lvanderree commented 2 months ago

Hmmm that is interesting. I haven't had this issue myself, but I will try to take a look at it, try if I can reproduce it myself.

I store a reference to all timers that are started here: https://github.com/lvanderree/com.synplyworks.thenmore/blob/master/app.js#L183C4-L183C11 So if the timer is dissapears from the list, it is supposed to have stopped, since besides cancelling that is the only reason to get removed from the list: https://github.com/lvanderree/com.synplyworks.thenmore/blob/master/app.js#L178

Maybe you can share more info about your flow, to make it possible to reproduce it for me...

shaarkys commented 2 months ago

Also in the timers list, timers seem to disappear automatically after a few seconds after starting

Probably similar issue to https://github.com/lvanderree/com.synplyworks.thenmore/issues/26#issue-1632622661 ?

stofferr commented 2 months ago

Currently testing alternative flow without Timer but Zone Activity instead , but I can try to recreate this tonight I hope.

From: Leon van der Ree @.> Sent: Monday, July 15, 2024 8:18 To: lvanderree/com.synplyworks.thenmore @.> Cc: stofferr @.>; Comment @.> Subject: Re: [lvanderree/com.synplyworks.thenmore] Cancelation of timers does not work. (Issue #28)

Hmmm that is interesting. I haven't had this issue myself, but I will try to take a look at it, try if I can reproduce it myself.

I store a reference to all timers that are started here: https://github.com/lvanderree/com.synplyworks.thenmore/blob/master/app.js#L183C4-L183C11 So if the timer is dissapears from the list, it is supposed to have stopped, since besides cancelling that is the only reason to get removed from the list: https://github.com/lvanderree/com.synplyworks.thenmore/blob/master/app.js#L178

Maybe you can share more info about your flow, to make it possible to reproduce it for me...

— Reply to this email directly, view it on GitHub https://github.com/lvanderree/com.synplyworks.thenmore/issues/28#issuecomment-2227769402 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTNUA4JWJ35SMWJSI5TSTTZMNSSPAVCNFSM6AAAAABK25RM5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXG43DSNBQGI . You are receiving this because you commented.Message ID: @.***>

stofferr commented 2 months ago

Could very well be indeed.

From: Shaarkys @.> Sent: Monday, July 15, 2024 10:14 To: lvanderree/com.synplyworks.thenmore @.> Cc: stofferr @.>; Comment @.> Subject: Re: [lvanderree/com.synplyworks.thenmore] Cancelation of timers does not work. (Issue #28)

Also in the timers list, timers seem to disappear automatically after a few seconds after starting

Probably similar issue to #26 (comment) https://github.com/lvanderree/com.synplyworks.thenmore/issues/26#issue-1632622661 ?

— Reply to this email directly, view it on GitHub https://github.com/lvanderree/com.synplyworks.thenmore/issues/28#issuecomment-2227930901 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTNUA2OFPECAVCM4VNIOQTZMOAE7AVCNFSM6AAAAABK25RM5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXHEZTAOJQGE . You are receiving this because you commented.Message ID: @.***>

stofferr commented 2 months ago

Very simple: Start a timer (OnOff device, Start when already on, Use longest timeouts) [image: image.png] While starting the timer, look at the app settings screen. On my HP23, the timer appears and it takes about 3 seconds before the timer disappears automagically. Or the timer is not listed at all. Roger

On Mon, Jul 15, 2024 at 10:15 AM @.***> wrote:

Could very well be indeed.

From: Shaarkys @.> Sent: Monday, July 15, 2024 10:14 To: lvanderree/com.synplyworks.thenmore < @.> Cc: stofferr @.>; Comment < @.> Subject: Re: [lvanderree/com.synplyworks.thenmore] Cancelation of timers does not work. (Issue #28)

Also in the timers list, timers seem to disappear automatically after a few seconds after starting

Probably similar issue to #26 (comment) https://github.com/lvanderree/com.synplyworks.thenmore/issues/26#issue-1632622661 ?

— Reply to this email directly, view it on GitHub https://github.com/lvanderree/com.synplyworks.thenmore/issues/28#issuecomment-2227930901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTNUA2OFPECAVCM4VNIOQTZMOAE7AVCNFSM6AAAAABK25RM5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXHEZTAOJQGE . You are receiving this because you commented.[image: Image removed by sender.]Message ID: <lvanderree/com.synplyworks.thenmore/issues/28/ @.***>

stofferr commented 2 months ago

DiagID: eccab7b0-7182-45b8-ab09-11f9d834b670

On Mon, Jul 15, 2024 at 3:09 PM Roger Stoffers @.***> wrote:

Very simple: Start a timer (OnOff device, Start when already on, Use longest timeouts) [image: image.png] While starting the timer, look at the app settings screen. On my HP23, the timer appears and it takes about 3 seconds before the timer disappears automagically. Or the timer is not listed at all. Roger

On Mon, Jul 15, 2024 at 10:15 AM @.***> wrote:

Could very well be indeed.

From: Shaarkys @.> Sent: Monday, July 15, 2024 10:14 To: lvanderree/com.synplyworks.thenmore < @.> Cc: stofferr @.>; Comment < @.> Subject: Re: [lvanderree/com.synplyworks.thenmore] Cancelation of timers does not work. (Issue #28)

Also in the timers list, timers seem to disappear automatically after a few seconds after starting

Probably similar issue to #26 (comment) https://github.com/lvanderree/com.synplyworks.thenmore/issues/26#issue-1632622661 ?

— Reply to this email directly, view it on GitHub https://github.com/lvanderree/com.synplyworks.thenmore/issues/28#issuecomment-2227930901, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJTNUA2OFPECAVCM4VNIOQTZMOAE7AVCNFSM6AAAAABK25RM5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXHEZTAOJQGE . You are receiving this because you commented.[image: Image removed by sender.]Message ID: <lvanderree/com.synplyworks.thenmore/issues/28/ @.***>

stofferr commented 2 months ago

I created this flow: image

The first time I ran it, it worked flawlessly. The second time I ran it, on both timer start cards, for each, after 2-3 seconds, the timer automagically disappears.

DiagID: a6807319-a366-41d4-8790-8ced8f79a76c