search

lvandeve / lodepng

PNG encoder and decoder in C and C++.
zlib License
2.04k stars 420 forks source link

Remove lodepng_auto_choose_color prototype #121

Closed amirgon closed 4 years ago

amirgon commented 4 years ago

lodepng_auto_choose_color definition was removed on 430268baa882a707c36b356402b94ab14dc08b69. Removing orphan prototype.

lvandeve commented 4 years ago

It turns out that it was not orphaned, but had a wrong typename in the signature, stats should have the type "LodePNGColorStats" instead of "LodePNGColorMode"

However, the fact that this could exist with that bug unnoticed is a sign that it's not externally needed, so this is a good opportunity to reduce the external API size, so I'll gladly accept this.

EDIT: oh indeed the corresponding function also has different name in the source file, making it indeed even more unneeded. Thanks!