search

lvandeve / lodepng

PNG encoder and decoder in C and C++.
zlib License
2.03k stars 420 forks source link

fixed MSVC warnings #142

Closed kajott closed 7 months ago

kajott commented 3 years ago

Fixed some warnings that occur when compiling with Microsoft's compiler, especially in 64-bit mode. As a side effect, this also makes the use of unsigned vs. size_t slightly more logical in some places.

This fixes #67.

reynoldsbd commented 2 years ago

Hey @lvandeve, is there something I can do to help get this PR across the finish line? My team would like to use lodepng, but in order to do so it needs to be free of most MSVC compiler warnings.

yoavmil commented 2 years ago

I second this PR

reynoldsbd commented 2 years ago

@lvandeve gentle ping - is there anything I can do to help get this PR merged?

fbertrand27 commented 1 year ago

Was about to post an issue about these, @Ivandeve can this get integrated? Thank you!

angusgraham commented 1 year ago

Would also love to see this integrated. Every time these warnings stream by it bugs me a little bit. :-)

lvandeve commented 7 months ago

Hey, thanks for the fixes! One thing, the function lodepng_chunk_create's signature should also be changed in the header to match the change. Thanks!

kajott commented 7 months ago

Good catch. Admittedly, I only ever tested with lodepng.cpp, not lodepng.c. The new commit (87032dd) should fix the C-specific issues too.

lvandeve commented 7 months ago

Thanks!