search

lvandeve / lodepng

PNG encoder and decoder in C and C++.
zlib License
2.04k stars 420 forks source link

code style #96

Closed zvezdochiot closed 3 years ago

zvezdochiot commented 4 years ago

https://github.com/lvandeve/lodepng/blob/39aaf874236f1341deb58548105198d59ab56a2e/lodepng.cpp#L886-L890

to

  for(i =   0; i < 144; ++i) bitlen[i] = 8;
  for(i = 144; i < 256; ++i) bitlen[i] = 9;
  for(i = 256; i < 280; ++i) bitlen[i] = 7;
  for(i = 280; i < 288; ++i) bitlen[i] = 8;

https://github.com/lvandeve/lodepng/blob/39aaf874236f1341deb58548105198d59ab56a2e/lodepng.cpp#L2986-L3012

to

      *a = (mode->key_defined && *r == mode->key_r) ? 0 : 255;

Not?

zvezdochiot commented 3 years ago

⚠️ Not resolved !!!