Closed GoogleCodeExporter closed 9 years ago
FYI - I have used the trunk version of the reinsert_wordalign.pm module.
Original comment by toma...@moravia.com
on 27 Nov 2013 at 2:10
Hi Tomas,
Thanks a lot for the unit-test and for checking this. You're certainly right
and it should be ok now.
I didn't want to resolve this issue while pushing the latest fix because I
wanted to comment on something:
Please note that the expected result for sub "test_complex" is not accurate.
Default behaviour for tags is to be associated to the tokens following the tag;
in this empty tag pair case, tag <g> will be associated to "to", not to "icon",
thus, reordering won't affect the output. You could move the tag pair before
"icon" to test it correctly.
Also there is a typo on <g id="1>, should be <g id="1">.
Regards,
Daniel
Original comment by dani.ros...@gmail.com
on 3 Dec 2013 at 9:10
Hi Daniel,
Thank you for explanation about the alignment ordering rules. I have updated
the testcase according to your advice and it works fine now. Code is checked in
now.
Moreover, the remaining issues appear fixed as well with your latest update
from Dec 2. Thus thanks a lot for the fix!
I think we can close the issue now.
Original comment by toma...@moravia.com
on 5 Dec 2013 at 1:48
Original comment by toma...@moravia.com
on 5 Dec 2013 at 1:49
Original issue reported on code.google.com by
toma...@moravia.com
on 27 Nov 2013 at 2:09