Consider use of "favicons-webpack-plugin"

lvarayut / relay-fullstack

:point_up::running: Modern Relay Starter Kit - Integrated with Relay, GraphQL, Express, ES6/ES7, JSX, Webpack, Babel, Material Design Lite, and PostCSS

https://lvarayut.github.io/relay-fullstack/

MIT License

986 stars 126 forks source link

Consider use of "favicons-webpack-plugin" #27

Closed RyLeeHarrison closed 8 years ago

RyLeeHarrison commented 8 years ago

In the interest of improvement and further movement of the project, I recommend the use of the simple favicons webpack plugin dependency, because it will reduce the size of the application, clean up the HTML template, offer more user customizable features for their particular use case.

lvarayut commented 8 years ago

Thanks for your suggestion. I have tried the plugin few months ago. At that time, it was very early stage and had some potential problem, I don't remember exactly what it was. However, the plugin might be improved and definitely worth to try. I'll check it out asap. Any PR will also be very welcomed.

RyLeeHarrison commented 8 years ago

Excellent!

lvarayut commented 8 years ago

Implemented in 497de427b1b69e9bf3405ab8c2c1ccb9cc03e5e2 :)