Remove --ignore-path from eslint config

lvarayut / relay-fullstack

:point_up::running: Modern Relay Starter Kit - Integrated with Relay, GraphQL, Express, ES6/ES7, JSX, Webpack, Babel, Material Design Lite, and PostCSS

https://lvarayut.github.io/relay-fullstack/

MIT License

985 stars 126 forks source link

Remove --ignore-path from eslint config #81

Closed BlakeBrown closed 7 years ago

BlakeBrown commented 7 years ago

We currently have --ignore-path set in the eslint hook for git commits. This forces eslint to ignore the .eslintignore file, which is the standard way of specifying files & folders you don't want to be linted.

I was trying to add .eslintignore to my repo and spent a while trying to figure out why my files were still being linted. It's unintuitive to have this flag set by default.

ps. we probably shouldn't be linting the .gitignore file either :P

lvarayut commented 7 years ago

Thanks for the awesome PR 👍 Could you do the same with the canary branch?

BlakeBrown commented 7 years ago

Totally! Sorry I wasn't aware you had two separate production branches.

I'll push a PR up when I have some extra time.