lvarayut / relay-fullstack

:point_up::running: Modern Relay Starter Kit - Integrated with Relay, GraphQL, Express, ES6/ES7, JSX, Webpack, Babel, Material Design Lite, and PostCSS
https://lvarayut.github.io/relay-fullstack/
MIT License
986 stars 126 forks source link

Warnings about PropTypes and React.createClass #84

Closed graforlock closed 7 years ago

graforlock commented 7 years ago

Just cloned and did npm install and when it compiles, console shows:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
Warning: RouterContext: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

It did not do it a couple of days ago, i am guessing its something new?

Neitsch commented 7 years ago

Yep, FB merged a huge PR recently. Will fix, PR is also welcome.

Neitsch commented 7 years ago

All our React classes are ES6, this warning is coming from react-router, please file an issue there.

Neitsch commented 7 years ago

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

Neitsch commented 7 years ago

Thanks for reporting. I opened the PR, other than that we will have to wait for all dependencies to update. If this problem persists in two weeks, feel free to reopen, so that we find a workaround.