refactor: change spq_init(), spq_perform(), send_sparql() to move request control to spq_init()!

lvaudor / glitter

an R package which writes SPARQL queries

https://lvaudor.github.io/glitter

44 stars 5 forks source link

refactor: change spq_init(), spq_perform(), send_sparql() to move request control to spq_init()! #176

Closed maelle closed 1 year ago

maelle commented 1 year ago

Fix #165

endpoint now an argument of spq_init()
control object with all the httr2 stuff
dry_run is still an argument of spq_perform() because I feel it's not something one wants in spq_init(), it's only a tweak at the end of a pipeline if things don't work as expected.

maelle commented 1 year ago

@lvaudor the pkgdown failure looks spurious, since locally it works :thinking: I won't explore it for now, and I don't think it's a blocker for reviewing this PR. :innocent: