lvaudor / glitter

an R package which writes SPARQL queries
https://lvaudor.github.io/glitter
45 stars 4 forks source link

question about the HAL article #189

Open maelle opened 1 year ago

maelle commented 1 year ago

@lvaudor there's a ligne where you filter the names corresponding to your lab but without doing any arranging first, should we amend it?

maelle commented 1 year ago

I'd suggest fixing after we merge the PR.

lvaudor commented 1 year ago

I'm not sure how to arrange this... I do it entirely based on my "expert knowledge" of my (tentacular) lab ;-)

maelle commented 1 year ago

I mean the order of the names could change, which would make your code wrong, so could you add a call to spq_arrange() before the filtering?