lvc / abi-compliance-checker

A tool for checking backward API/ABI compatibility of a C/C++ library
https://lvc.github.io/abi-compliance-checker/
GNU Lesser General Public License v2.1
621 stars 76 forks source link

Error on -sort option #126

Open junkangler opened 8 months ago

junkangler commented 8 months ago

Error occurs with -sort option: Undefined subroutine &main::dump_sorting called at /usr/lib/x86_64-linux-gnu/perl/5.34/Data/Dumper.pm line 449.

I think dump_sorting should be dumpSorting: if($In::Opt{"SortDump"}) { $Data::Dumper::Useperl = 1; $Data::Dumper::Sortkeys = \&dump_sorting; }

xiacunshun commented 6 months ago

You are right. It is a mistake. I think it because it is recommanded that abi-dumper is used to dump symbols then using ABICC to check the dump file.

xiacunshun commented 6 months ago

https://github.com/xiacunshun/abi-compliance-checker/commit/d58fb8f68d7ce0acc4aa739fda08dcee26d664b4