this static ctor changes the default JSON serialization settings in the application.
I think this is a problem, since other code may rely on the "default" set of defaults.
I don't expect a library to change the global settings in my application..
For example, in the application I'm working on now, we have many integrations with many 3rd party APIs.
I spent more time than I would've liked trying to figure out why an integration with service X was working as expected normally, but not working only on certain servers / certain customers.
turns out that, as long as the bitbucket integration wasn't turned on, everything was great. but once we turned on integration for bitbucket AND service X, service X stopped working as expected.
that's because Bitbucket.NET changed how the requests to service X were serialized!
this static ctor changes the default JSON serialization settings in the application. I think this is a problem, since other code may rely on the "default" set of defaults. I don't expect a library to change the global settings in my application..
For example, in the application I'm working on now, we have many integrations with many 3rd party APIs. I spent more time than I would've liked trying to figure out why an integration with service X was working as expected normally, but not working only on certain servers / certain customers. turns out that, as long as the bitbucket integration wasn't turned on, everything was great. but once we turned on integration for bitbucket AND service X, service X stopped working as expected. that's because
Bitbucket.NETchanged how the requests to service X were serialized!