search

lvermeulen / Bitbucket.Net

C# client for Atlassian Bitbucket Server
MIT License
32 stars 18 forks source link

please provide a signed nuget package on top of current unsigned #4

Closed jmecosta closed 5 years ago

jmecosta commented 5 years ago

hi in our context we need a signed dll, could you provide one? thanks

lvermeulen commented 5 years ago

I won't be providing a signed package (since I would need to put the private key in the repo, which kind of defeats the purpose), but you can do this yourself with the package StrongNameSigner.

lvermeulen commented 4 years ago

I finally bit the bullet and am providing a signed assembly starting from release 2.1.9.

jmecosta commented 4 years ago

Wow thanks, what made you change your mind? Maybe i can use the same argument to convince other people 😉

On Sat, 4 Jan 2020, 18:40 Luk Vermeulen, notifications@github.com wrote:

I finally bit the bullet and am providing a signed assembly starting from release 2.1.9.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lvermeulen/Bitbucket.Net/issues/4?email_source=notifications&email_token=AAH6HSBU2LYG4YDDEA5MXVTQ4C3ZTA5CNFSM4FX6E7IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIC3OAI#issuecomment-570799873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6HSGT3YLUINN6I7Q4OBTQ4C3ZTANCNFSM4FX6E7IA .

lvermeulen commented 4 years ago

The arguments from the .NET Core team that signing is for identity, not security. And seeing that libraries such as MediatR and AutoMapper have been doing this for a while. And seeing that this wasn't all that much of a big deal for me to do. :-)

jmecosta commented 4 years ago

All good reasons indeed 🙂 thanks again

On Sun, 5 Jan 2020, 18:15 Luk Vermeulen, notifications@github.com wrote:

The arguments from the .NET Core team that signing is for identity, not security. And seeing that libraries such as MediatR and AutoMapper have been doing this for a while. And seeing that this wasn't all that much of a big deal for me to do. :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lvermeulen/Bitbucket.Net/issues/4?email_source=notifications&email_token=AAH6HSBSNMXLGTNINX46HVDQ4IBTFA5CNFSM4FX6E7IKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEID2EPI#issuecomment-570925629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6HSEMCOAMGTRN2EY56GLQ4IBTFANCNFSM4FX6E7IA .