lvermeulen / Keycloak.Net

C# client for Keycloak 6.x
MIT License
203 stars 120 forks source link

Upgrade Keycloak 17+ (parameterized the endpoint /auth ) #79

Open psavva opened 2 years ago

psavva commented 2 years ago

Upgraded to net-6.0 Upgraded Flur Library Removed compatibility for .net classic Removed compatibility for .net standard 1.x

psavva commented 2 years ago

@lvermeulen Please review.

pocketken commented 2 years ago

@psavva technically, the prefix is actually configurable. It no longer defaults to /auth, but, administrators are still free to configure it with whatever prefix they want when reverse proxying -- we add /auth back in our environment, for example.

Maybe it'd be handy for it to be configurable here too?

psavva commented 2 years ago

@pocketken fair point, I'll update the PR accordingly

akloster commented 1 year ago

@psavva is there a nuget package I could install which can vary the "auth" path?

This repository hasn't been updated since May 2021.

psavva commented 1 year ago

Not yet

mesutpiskin commented 1 year ago

I think this pr should be marge

psavva commented 1 year ago

I have updated the PR to include the path.

You can now do something like this: No path (ie: Keycloak 17+): new KeycloakClient(url: url, userName: userName, password: password, prefix:null); With Path (ie Keycloak 16-): new KeycloakClient(url: url, userName: userName, password: password, prefix:"auth");

psavva commented 1 year ago

@lvermeulen Please see if you can review, and bring this one in.. I think it will help a lot of people :)

Thank you for the awesome work on this project

digitalddq commented 1 year ago

@lvermeulen can this PR please be merged? With kubernetes operator (v19) based deployments, I don't see any way to adjust the endpoint name, it is a blocker in this case.

Using KC 19 we have adjusted the code and built our private NuGets as a workaround. I would really appreciate it, if it's solved in the main repo.

CesarD commented 1 year ago

What is required to finally merge this PR? It's a blocker for me as well and I'm sure for many other people.