search

lvgig / tubular

Python package implementing transformers for pre processing steps for machine learning.
https://tubular.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
39 stars 14 forks source link

Consistent args and generic testing for other transformer groups #151

Open davidhopkinson26 opened 10 months ago

davidhopkinson26 commented 10 months ago

Sister ticket to #150.

What? This is a ticket for homogenising and implementing the generic tests for the transformers not covered by ticket #150. These comprise transformers where columns can only be a list, the transformer takes two columns specifically, or the columns are read from mapping/capping dictionaries. A list of the transformers can be read from the attached spreadsheet (see end of description).

Why? Have identified as part of scoping #138 and #68 that for usability it makes sense to keep some inconsistency in transformers columns arguments. In the creation of the generic testing framework discussed in #138, these transformers cannot be covered by the same test logic as those in #150 due to differing columns input arguments, and so have been moved to this ticket.

How? Replace implementation tests in each transformer with a set of tests which loop over each identified subset of the transformers, testing the functionality defined in BaseTransformer.

NB this ticket may be further broken up with one for each transformer group

Transformer Consistent Args Audit.xlsx

limlam96 commented 1 month ago

@davidhopkinson26, I think this is now fully captured by individual issues, am I okay to just close?