search

lvgig / tubular

Python package implementing transformers for pre processing steps for machine learning.
https://tubular.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
38 stars 14 forks source link

Created generic two column init tests and tidied test_EqualityChecker #240

Closed Chip2916 closed 5 months ago

Chip2916 commented 5 months ago

Looking to address two outstanding issues

204, generic init class for two column transformers 205, bring EqualityChecker test in line with new format

Hopefully this new generic class can be used for many of the date transformers, which use two columns as an input. At this stage these transformers take two separate args which are combined into a list, rather than the EqualityChecker which takes a list with two objects. After speaking with @limlam96 agreed that updating the date transformers to take as single arg sits outside this ticket.

'test_columns_non_list_error' seems to fail if anything other than string passed to pytest.mark.parametrize due to EqualityChecker reference to BaseTransformer which only accepts str or list, might be missing something here.

limlam96 commented 5 months ago

Looks good, could you just add an entry to the changelog?

Chip2916 commented 5 months ago

Looks good, could you just add an entry to the changelog?

Suree have done so now, also added ModeImputer comment to change log as did not do that when I refactored those tests