search

lvgig / tubular

Python package implementing transformers for pre processing steps for machine learning.
https://tubular.readthedocs.io/en/latest/index.html
BSD 3-Clause "New" or "Revised" License
37 stars 14 forks source link

Bring MeanResponseTransformer in line with new test set up #262

Open davidhopkinson26 opened 1 week ago

davidhopkinson26 commented 1 week ago

Bringing MeanResponseTransformer in line with the new testing set up.

Have noticed during this update that WeightColumnFitMixinTests and WeightColumnInitMixinTests might not be being used in other transformers we have already refactored so might be worth a quick audit.

WeightColumnFitMixinTests has a lot of calls to fit without a y argument. In this case this was making things fail as i would expect but i am a bit concerned that applying these tests to GroupRareLevelsTransformer in #259 appeared to work fine. Warrants a deeper look.