What?
Move test_original_df_not_updated from test_BaseNominalTrasformer.GenericBaseNominalTransformerTests to base_tests.GenericTransformTests
Why?
Identified in #259 This tests that transform does not modify the provided dataframe in place. This is desirable behaviour across all transformers but is currently only tested in the nominal module. Moving it to GenericTransformTests will mean that the test will be inherited by test modules for every transformer.
How?
Move the test across to GenericTransformTests
Address any issues raised by failing tests as a result of change or create an overwriting test with the same name in the specific transformers test module and mark it with @pytest.mark.xfail and raise a separate issue to resolve.
What? Move test_original_df_not_updated from test_BaseNominalTrasformer.GenericBaseNominalTransformerTests to base_tests.GenericTransformTests
Why? Identified in #259 This tests that transform does not modify the provided dataframe in place. This is desirable behaviour across all transformers but is currently only tested in the nominal module. Moving it to GenericTransformTests will mean that the test will be inherited by test modules for every transformer.
How? Move the test across to GenericTransformTests Address any issues raised by failing tests as a result of change or create an overwriting test with the same name in the specific transformers test module and mark it with @pytest.mark.xfail and raise a separate issue to resolve.