search

lvgl-micropython / lvgl_micropython

LVGL module for MicroPython
MIT License
80 stars 25 forks source link

o_char and e_char are always empty, then returncode is None #25

Closed cheops closed 7 months ago

cheops commented 7 months ago

by line 282 o_char and e_char are always empty since while o_char != b'': and while e_char != b'': will have done their job

when this break is executed, it might be that p.poll() has not yet filled in the returncode This might result in all kind of strange behavior if the result of spawn is checked and found to be None in stead of 0

Same concern for the break for prompt. Maybe after o_buf = read() a call should be added p.wait() to ensure the child process has terminated?

kdschlosser commented 7 months ago

I am actually going to be redoing how the subprocesses are handled. It's turned into a monster is what it has done and I need to clean it up. Parsing subprocess output can be a royal pain to do especially when the process needs to run for a long time which is the case here.

kdschlosser commented 7 months ago

I fixed the build. I wrote the spawn function over again. It has a smaller code footprint now and it should have less of an issue working.

cheops commented 7 months ago

build for esp32 (on WSL-ubuntu) works again you may close and disregard this pull request :-)