lvgl / lv_binding_micropython

LVGL binding for MicroPython
MIT License
237 stars 157 forks source link

Various upstreams still point to littlevgl, also found in URLs #141

Closed ropg closed 3 years ago

ropg commented 3 years ago

Perform all steps below and tick them with [x]

Describe the bug

When cloning, my github client wil warn me that the upstream set for submodules does not match where they came from, giving me littlevgl URLs instead.

To Reproduce

One example of many, from lv_micropython/.gitmodules:

[submodule "lib/lv_bindings"]
    path = lib/lv_bindings
    url = https://github.com/littlevgl/lv_bindings.git

Expected behavior

No deprecated URLs

Screenshots or video

Nah...

Offer

If that's appreciated I can go through at least everything related to micropython and fix it all where appropriate in a single PR per repo. But I'd first want to know that I'm not messing with things that will be cleaned anyway, or ...

kisvegabor commented 3 years ago

Thanks for pointing it out. I moved the issue to the lv_binding_micropython repo.

amirgon commented 3 years ago

Offer

If that's appreciated I can go through at least everything related to micropython and fix it all where appropriate in a single PR per repo. But I'd first want to know that I'm not messing with things that will be cleaned anyway, or ...

I just ignored these warnings so far.
If you are willing to fix this, a PR would be appreciated!

amirgon commented 3 years ago

Fixed by https://github.com/lvgl/lv_micropython/pull/26

Thanks.