driver/generic/ft6x36.py: now also works with v8

lvgl / lv_binding_micropython

LVGL binding for MicroPython

MIT License

237 stars 156 forks source link

driver/generic/ft6x36.py: now also works with v8 #149

Closed ropg closed 3 years ago

ropg commented 3 years ago

Between v7 and v8 the enum for INDEV_STATE has changed so that INDEV_STATE.PR and INDEV_STATE.REL are now INDEV_STATE.PRESSED and INDEV_STATE.RELEASED respectively. I now check lv.version_major() and use accordingly.

(Or would you prefer two versions of the driver?)

ropg commented 3 years ago

Thinking about it more this makes no sense: there would be comparisons all over, and clearly the right answer is to have a different driver for v8, as well as a new minimal example.

(I think this make a good argument against trivial changes like this.)